Fix GNU build error #468
Merged
Fix GNU build error #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit aecb998 ("Fixes perfect restart issue in the ICE_SHELF module", 2017-04-07) introduced calls to `pass_var()` within a subroutine whose `ocean_grid_type` structure was `intent(in)`. Most compilers seem to be happy with this, but certain versions of gfortran would fail with the following error: call pass_var(CS%area_shelf_h, G%domain) 1 Error: Procedure argument at (1) is INTENT(IN) while interface specifies INTENT(INOUT) Changing the argument to `intent(inout)` fixes this.
|
@angus-g, Thanks for catching and fixing that. |
alex-huth
added a commit
to alex-huth/MOM6
that referenced
this pull request
Oct 10, 2023
Previously, when ice_viscosity_compute == MODEL, ice shelf viscosity was calculated using 1 quadrature point per cell; however, this quadrature point was not centered in the cell. -Added a routine bilinear_shape_fn_grid_1qp, which is used to instead calculate viscosity for a single cell-centered quadrature point -Added an option to define parameter ice_viscosity_compute = MODEL_QUADRATURE, where viscosity is calculated at the same four quadrature points used during the SSA solution (the typical approach in finite element codes). Note that when using one quadrature point (ice_viscosity_compute == MODEL), array ice_visc(:,:) is the cell-centered ice viscosity. When using four quadrature points (ice_viscosity_compute == MODEL_QUADRATURE), ice_visc(:,:) is the cell-centered ice viscosity divided by the effective stress, Ee, which varies between each quadrature point and is saved in a separate array CS%Ee(:,:,:). In the SSA, ice viscosity is calculated for a cell with indices i,j as ice_visc(i,j) * Ee, where Ee=1 if using one quadrature point for viscosity and Ee=CS%Ee(i,j,k) if using four quad points (where k the current quad point). Also note the post_data call for ice_visc when using four quad points, where Ice_visc is outputted for visualization from a cell as ice_visc(i,j)*Ee_av(i,j), where Ee_av(i,j) is the average Ee in the cell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit aecb998 ("Fixes perfect restart issue in the ICE_SHELF module", 2017-04-07) introduced calls to
pass_var()within a subroutine whoseocean_grid_typestructure wasintent(in). Most compilers seem to be happy with this, but certain versions of gfortranwould fail with the following error:
Changing the argument to
intent(inout)fixes this.